42 lines
1.9 KiB
Diff
42 lines
1.9 KiB
Diff
From afa206dc466066c3d273dfc879103700505b3d7b Mon Sep 17 00:00:00 2001
|
|
From: Joshua Strobl <joshua@streambits.io>
|
|
Date: Sun, 22 Aug 2021 14:02:05 +0300
|
|
Subject: [PATCH 1/1] Disable crash reporter since Microsoft refuses to fix
|
|
this upstream.
|
|
|
|
Unfortunately a PR submitted by a third-party was rejected by Microsoft, which would change the default for crash reporting from true to false and move the telemetry configuration to ensure crash reporting was not being forced on, placed in the argv.json, and cause a crash when improperly set.
|
|
|
|
So, disable it entirely. No cookies for you, Visual Studio Code team.
|
|
---
|
|
src/bootstrap-fork.js | 3 ---
|
|
src/main.js | 16 ----------------
|
|
src/vs/code/electron-main/app.ts | 2 +-
|
|
3 files changed, 1 insertion(+), 20 deletions(-)
|
|
|
|
diff --git a/src/main.js b/src/main.js
|
|
index f7e6e49a967..88513af6dec 100644
|
|
--- a/src/main.js
|
|
+++ b/src/main.js
|
|
@@ -46,21 +46,6 @@ const argvConfig = configureCommandlineSwitchesSync(args);
|
|
// Disable default menu (https://github.com/electron/electron/issues/35512)
|
|
Menu.setApplicationMenu(null);
|
|
|
|
-// Configure crash reporter
|
|
-perf.mark('code/willStartCrashReporter');
|
|
-// If a crash-reporter-directory is specified we store the crash reports
|
|
-// in the specified directory and don't upload them to the crash server.
|
|
-//
|
|
-// Appcenter crash reporting is enabled if
|
|
-// * enable-crash-reporter runtime argument is set to 'true'
|
|
-// * --disable-crash-reporter command line parameter is not set
|
|
-//
|
|
-// Disable crash reporting in all other cases.
|
|
-if (args['crash-reporter-directory'] || (argvConfig['enable-crash-reporter'] && !args['disable-crash-reporter'])) {
|
|
- configureCrashReporter();
|
|
-}
|
|
-perf.mark('code/didStartCrashReporter');
|
|
-
|
|
// Set logs path before app 'ready' event if running portable
|
|
// to ensure that no 'logs' folder is created on disk at a
|
|
// location outside of the portable directory
|