From 2b48780fc47c8acd77fe974ff7411d1be23eeabe Mon Sep 17 00:00:00 2001 From: Nathan Owens Date: Fri, 4 Jan 2019 15:01:03 -0600 Subject: [PATCH] gthumb: fix CVE-2018-18718 --- srcpkgs/gthumb/patches/cve-2018-18718.patch | 21 +++++++++++++++++++++ srcpkgs/gthumb/template | 6 +++--- 2 files changed, 24 insertions(+), 3 deletions(-) create mode 100644 srcpkgs/gthumb/patches/cve-2018-18718.patch diff --git a/srcpkgs/gthumb/patches/cve-2018-18718.patch b/srcpkgs/gthumb/patches/cve-2018-18718.patch new file mode 100644 index 00000000000..4280ef0bb37 --- /dev/null +++ b/srcpkgs/gthumb/patches/cve-2018-18718.patch @@ -0,0 +1,21 @@ +Description: CVE-2018-18718 + An issue was discovered in gThumb through 3.6.2. There is a + double-free vulnerability in the add_themes_from_dir method in + dlg-contact-sheet.c because of two successive calls of g_free, + each of which frees the same buffer. + Thanks Tianjun Wu - https://gitlab.gnome.org/leoaccount + https://gitlab.gnome.org/GNOME/gthumb/issues/18 +Author: Herbert Parentes Fortes Neto +Last-Update: 2018-10-30 +Index: gthumb/extensions/contact_sheet/dlg-contact-sheet.c +=================================================================== +--- extensions/contact_sheet/dlg-contact-sheet.c ++++ extensions/contact_sheet/dlg-contact-sheet.c +@@ -352,6 +352,7 @@ add_themes_from_dir (DialogData *data, + if (! g_key_file_load_from_data (key_file, buffer, size, G_KEY_FILE_NONE, NULL)) { + g_key_file_free (key_file); + g_free (buffer); ++ buffer = NULL; + g_object_unref (file); + g_object_unref (file_info); + } diff --git a/srcpkgs/gthumb/template b/srcpkgs/gthumb/template index 870498afc28..7b686db044b 100644 --- a/srcpkgs/gthumb/template +++ b/srcpkgs/gthumb/template @@ -1,7 +1,7 @@ # Template file for 'gthumb' pkgname=gthumb version=3.6.2 -revision=2 +revision=3 build_style=gnu-configure configure_args="--disable-schemas-compile --disable-static $(vopt_enable tiff) $(vopt_enable clutter) @@ -13,11 +13,11 @@ makedepends="webkit2gtk-devel json-glib-devel gnome-desktop-devel $(vopt_if tiff tiff-devel) $(vopt_if clutter clutter-gtk-devel) $(vopt_if gstreamer gstreamer1-devel) $(vopt_if soup libsoup-gnome-devel) $(vopt_if brasero brasero-devel)" -short_desc='An image viewer and browser for the GNOME Desktop' +short_desc='Image viewer and browser for the GNOME Desktop' maintainer="Enguerrand de Rochefort " license="GPL-2.0-or-later" homepage="http://live.gnome.org/gthumb" -distfiles="${GNOME_SITE}/gthumb/${version%.*}/gthumb-${version}.tar.xz" +distfiles=${GNOME_SITE}/gthumb/${version%.*}/gthumb-${version}.tar.xz checksum=c9bf6bb7502659f5e990069527584bb96193f7f5f9492f0bf5f65828f5024b66 ## Package build options