snailed
/
void-packages
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Activity

common/chroot-style/uchroot.sh: check if xbps-uchroot is executable 

... and show a friendly error message

This can be a common failure mode when using `-t` if not in the group
`xbps-uchroot` is owned by, because it is SUID. Previously, the error was
the cryptic message `ERROR: prctl SECBIT_NOROOT (Operation not permitted)`.
This commit is contained in:
classabbyamp 2024-02-18 03:15:55 -05:00 committed by classabbyamp
parent ef6f71e377
commit 1a47dd3d9e
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
common/chroot-style/uchroot.sh
View File

@ -9,12 +9,27 @@ readonly EXTRA_ARGS="$4"
readonly CMD="$5" readonly CMD="$5"
shift 5 shift 5
if ! command -v xbps-uchroot >/dev/null 2>&1; then msg_red() {
# error messages in bold/red
[ -n "$NOCOLORS" ] || printf >&2 "\033[1m\033[31m"
printf "=> ERROR: %s\\n" "$@" >&2
[ -n "$NOCOLORS" ] || printf >&2 "\033[m"
}
readonly XBPS_UCHROOT_CMD="$(command -v xbps-uchroot 2>/dev/null)"
if [ -z "$XBPS_UCHROOT_CMD" ]; then
msg_red "could not find xbps-uchroot"
exit 1 exit 1
fi fi
if [ -z "$MASTERDIR" -o -z "$DISTDIR" ]; then if ! [ -x "$XBPS_UCHROOT_CMD" ]; then
echo "$0 MASTERDIR/DISTDIR not set" msg_red "xbps-uchroot is not executable. Are you in the $(stat -c %G "$XBPS_UCHROOT_CMD") group?"
exit 1
fi
if [ -z "$MASTERDIR" ] || [ -z "$DISTDIR" ]; then
msg_red "$0: MASTERDIR/DISTDIR not set"
exit 1 exit 1
fi fi