30 lines
869 B
Diff
30 lines
869 B
Diff
|
From a1f88e842e0216a5b4df1ab023caebe33c101395 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Matt Turner <mattst88@gmail.com>
|
||
|
|
Date: Wed, 2 Nov 2022 12:07:32 -0400
|
||
|
|
Subject: [PATCH] Avoid integer overflow leading to out-of-bounds write
|
||
|
|
|
||
|
|
Thanks to Maddie Stone and Google's Project Zero for discovering this
|
||
|
|
issue, providing a proof-of-concept, and a great analysis.
|
||
|
|
|
||
|
|
Closes: https://gitlab.freedesktop.org/pixman/pixman/-/issues/63
|
||
|
|
---
|
||
|
|
pixman/pixman-trap.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/pixman/pixman-trap.c b/pixman/pixman-trap.c
|
||
|
|
index 91766fd..7560405 100644
|
||
|
|
--- a/pixman/pixman-trap.c
|
||
|
|
+++ b/pixman/pixman-trap.c
|
||
|
|
@@ -74,7 +74,7 @@ pixman_sample_floor_y (pixman_fixed_t y,
|
||
|
|
|
||
|
|
if (f < Y_FRAC_FIRST (n))
|
||
|
|
{
|
||
|
|
- if (pixman_fixed_to_int (i) == 0x8000)
|
||
|
|
+ if (pixman_fixed_to_int (i) == 0xffff8000)
|
||
|
|
{
|
||
|
|
f = 0; /* saturate */
|
||
|
|
}
|
||
|
|
--
|
||
|
|
GitLab
|
||
|
|
|