30 lines
918 B
Diff
30 lines
918 B
Diff
|
From 187ff3e80b8d6b447e584708d88a1858e154a348 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
|
||
|
|
Date: Fri, 11 Oct 2013 19:33:36 -0400
|
||
|
|
Subject: [PATCH] drop-ins: check return value
|
||
|
|
|
||
|
|
If the function failed, nothing serious would happen
|
||
|
|
because unlink would probably return EFAULT, but this
|
||
|
|
would obscure the real error and is a bit sloppy.
|
||
|
|
---
|
||
|
|
src/core/unit.c | 3 +++
|
||
|
|
1 file changed, 3 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/src/core/unit.c b/src/core/unit.c
|
||
|
|
index 4b97710..1db7d06 100644
|
||
|
|
--- a/src/core/unit.c
|
||
|
|
+++ b/src/core/unit.c
|
||
|
|
@@ -2908,6 +2908,9 @@ int unit_remove_drop_in(Unit *u, UnitSetPropertiesMode mode, const char *name) {
|
||
|
|
return 0;
|
||
|
|
|
||
|
|
r = drop_in_file(u, mode, name, &p, &q);
|
||
|
|
+ if (r < 0)
|
||
|
|
+ return r;
|
||
|
|
+
|
||
|
|
if (unlink(q) < 0)
|
||
|
|
r = errno == ENOENT ? 0 : -errno;
|
||
|
|
else
|
||
|
|
--
|
||
|
|
1.8.4.652.g0d6e0ce
|
||
|
|
|